Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set security context of workloads #1325

Merged

Conversation

jacobbaungard
Copy link
Contributor

This commit sets the following security context of all workloads
directly handled by the operator:

securityContext:
    privileged: false
    readOnlyRootFilesystem: true

this as required by: RHOBS-1001

@jacobbaungard
Copy link
Contributor Author

/hold (will release once all PRs have been tested e2e)

@jacobbaungard
Copy link
Contributor Author

/retest-required

@jacobbaungard jacobbaungard force-pushed the set-security-context branch 2 times, most recently from e372071 to d61fc09 Compare February 13, 2024 10:36
@jacobbaungard
Copy link
Contributor Author

/retest

@philipgough
Copy link
Contributor

/retest-required

@jacobbaungard
Copy link
Contributor Author

/test test-e2e
/test e2e-kind

@jacobbaungard
Copy link
Contributor Author

/retest

1 similar comment
@jacobbaungard
Copy link
Contributor Author

/retest

@jacobbaungard
Copy link
Contributor Author

/retest

@jacobbaungard jacobbaungard force-pushed the set-security-context branch 2 times, most recently from f2db06b to 6b94e1e Compare February 14, 2024 15:57
@jacobbaungard
Copy link
Contributor Author

/retest

Formatting was borked, making them hard to edit. Ran select ones through
yamlfmt.

Signed-off-by: Jacob Baungard Hansen <[email protected]>
@jacobbaungard
Copy link
Contributor Author

/retest

1 similar comment
@jacobbaungard
Copy link
Contributor Author

/retest

This commit sets the following security context of all workloads
directly handled by the operator:

```
securityContext:
    privileged: false
    readOnlyRootFilesystem: true
```

this as required by: RHOBS-1001

Signed-off-by: Jacob Baungard Hansen <[email protected]>
This commit sets the following security context for the metric collector
pods:

```
securityContext:
    privileged: false
    readOnlyRootFilesystem: true
```

this as required by: RHOBS-1001

Signed-off-by: Jacob Baungard Hansen <[email protected]>
This commit sets the following security context for the
endpoint-observability-operator

```
securityContext:
    privileged: false
    readOnlyRootFilesystem: true
```

this as required by: RHOBS-1001

Signed-off-by: Jacob Baungard Hansen <[email protected]>
Otherwise fsGroup in the security context fails.

Signed-off-by: Jacob Baungard Hansen <[email protected]>
Copy link

@jacobbaungard
Copy link
Contributor Author

/retest

- observatorium-operator
topologyKey: topology.kubernetes.io/zone
weight: 70
- podAffinityTerm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the yaml is being formatted differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some formatting inconsistencies before (or at least my eyes struggled with the formatting), so I ran the files I needed to change through yamllint as I found it hard to make changes correctly otherwise.

@moadz
Copy link
Contributor

moadz commented Feb 19, 2024

/approve

Copy link

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, moadz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,moadz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobbaungard
Copy link
Contributor Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit e4130bd into stolostron:main Feb 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants